chore(deps): upgrade frontend to Angular 19#4445
Merged
Merged
Conversation
Contributor
|
@zuozhiw @Xiao-zhen-Liu Can you review this PR? |
Signed-off-by: Xinyuan Lin <xinyual3@uci.edu>
Signed-off-by: Xinyuan Lin <xinyual3@uci.edu>
Xiao-zhen-Liu
requested changes
Apr 24, 2026
Contributor
Xiao-zhen-Liu
left a comment
There was a problem hiding this comment.
Tested locally and no major issues seen. But there are a few compatibility issues I see.
7a8190e to
509ea2d
Compare
529c1ed to
4569766
Compare
Contributor
Author
|
@Xiao-zhen-Liu comments addressed, please review again. |
Contributor
Author
|
@Yicong-Huang, do you know how to remove the old CIs? I bumped node from 18 to 20, but the CI for node 18 is still pending. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
19.2.x.19.2.24.20.19.0.@angular/cdkto19.2.19ng-zorro-antdto19.3.1ngx-markdownto19.1.1markedto15.0.12zone.jsto0.15.1@nx/angular/nxto21.6.11@typescript-eslint/*to8.59.0explicit-standalone-flagmigration to preserve existing NgModule declarations under Angular 19.browserTargettobuildTarget.yarn buildto use an 8 GB Node heap, matching the existing CI build memory behavior.typescriptpinned at5.5.4to avoid deep type-instantiation errors seen with5.8.x.Any related issues, documentation, discussions?
Closes #4431.
How was this PR tested?
yarn.cmd installyarn.cmd buildyarn.cmd build:ciyarn.cmd test --watch=falseyarn.cmd ng serveWas this PR authored or co-authored using generative AI tooling?
Generated-by: Codex